Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow covariates in plot_expected_purchases #1430

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

PabloRoque
Copy link
Contributor

@PabloRoque PabloRoque commented Jan 24, 2025

Description

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1430.org.readthedocs.build/en/1430/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation CLV tests labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 60 lines in your changes missing coverage. Please review.

Project coverage is 59.19%. Comparing base (10f34c5) to head (74de286).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/clv/models/beta_geo.py 21.12% 56 Missing ⚠️
pymc_marketing/clv/utils.py 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (10f34c5) and HEAD (74de286). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (10f34c5) HEAD (74de286)
11 7
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1430       +/-   ##
===========================================
- Coverage   94.52%   59.19%   -35.34%     
===========================================
  Files          50       50               
  Lines        5386     5472       +86     
===========================================
- Hits         5091     3239     -1852     
- Misses        295     2233     +1938     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColtAllen
Copy link
Collaborator

I'll review this in detail later, but it looks like there may be merge conflicts with #1390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV docs Improvements or additions to documentation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants