Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved pyprojroot from docs to dependencies #1417

Merged

Conversation

nayan2167
Copy link
Contributor

@nayan2167 nayan2167 commented Jan 20, 2025

Description

Modified pyproject.toml file, moved pyprojroot from docs to dependencies, now pyprojroot will be installed with the dependencies instead of just docs.

Related Issue

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1417.org.readthedocs.build/en/1417/

@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package labels Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (2f6bc0a) to head (b44aa1b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   94.58%   94.51%   -0.08%     
==========================================
  Files          49       49              
  Lines        5338     5338              
==========================================
- Hits         5049     5045       -4     
- Misses        289      293       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622 wd60622 requested a review from juanitorduz January 20, 2025 17:13
@juanitorduz
Copy link
Collaborator

Thanks @nayan2167 but I do not think we actually need pyprojroot for pymc-marketing itself. It is mainly to run the examples (and tests)

@juanitorduz
Copy link
Collaborator

well, but is indeed in the package 🤔

@juanitorduz juanitorduz merged commit e8c7232 into pymc-labs:main Jan 20, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyprojectroot only installed in docs
2 participants