Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the type that is needed for evaluation metric function #1413

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jan 19, 2025

Description

Docstring example fix

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1413.org.readthedocs.build/en/1413/

@wd60622 wd60622 added docs Improvements or additions to documentation MMM labels Jan 19, 2025
@github-actions github-actions bot added the tests label Jan 19, 2025
@wd60622 wd60622 requested a review from juanitorduz January 19, 2025 19:48
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.56%. Comparing base (6f12316) to head (874e01a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/mlflow.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
- Coverage   94.57%   94.56%   -0.01%     
==========================================
  Files          48       48              
  Lines        5257     5266       +9     
==========================================
+ Hits         4972     4980       +8     
- Misses        285      286       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622 wd60622 changed the title Correct the evaluation docstring Relax the type that is needed for evaluation metric function Jan 19, 2025
@wd60622 wd60622 merged commit 5e83235 into main Jan 19, 2025
18 of 20 checks passed
@wd60622 wd60622 deleted the correct-evaluation-example branch January 19, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation mlflow MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants