Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #1391

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Add tests #1391

merged 6 commits into from
Jan 17, 2025

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Jan 16, 2025

Add test of some missing functions.


📚 Documentation preview 📚: https://pymc-marketing--1391.org.readthedocs.build/en/1391/

@github-actions github-actions bot added the tests label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (7a41a72) to head (1531e86).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/mmm/base.py 91.42% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   93.80%   94.59%   +0.78%     
==========================================
  Files          48       48              
  Lines        5198     5199       +1     
==========================================
+ Hits         4876     4918      +42     
+ Misses        322      281      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the MMM label Jan 16, 2025
@juanitorduz juanitorduz marked this pull request as draft January 16, 2025 19:33
@juanitorduz juanitorduz requested a review from wd60622 January 16, 2025 19:47
@juanitorduz juanitorduz marked this pull request as ready for review January 16, 2025 19:47
@juanitorduz juanitorduz merged commit c05311b into main Jan 17, 2025
19 of 20 checks passed
@juanitorduz juanitorduz deleted the add-tests branch January 17, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants