1271 predictions=true for sample posterior predictive throws error #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1272 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 42 42
Lines 4439 4440 +1
=======================================
+ Hits 4218 4219 +1
Misses 221 221 ☔ View full report in Codecov by Sentry. |
juanitorduz
approved these changes
Dec 13, 2024
|
This has the mypy issues. But I think they are the same as the other PR |
|
Or maybe not 😆 |
wd60622
deleted the
1271-predictions=true-for-sample_posterior_predictive-throws-error
branch
aseyboldt
pushed a commit
to aseyboldt/pymc-marketing
that referenced
this pull request
Dec 20, 2024
…ymc-labs#1272) * group conditional on the kwargs * flip the case * test for predictions kwarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The extracted group is conditional on the kwargs if
predictions=TrueRelated Issue
Checklist
Modules affected
Type of change