Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when two dims are not compatible #1249

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Dec 2, 2024

Description

Bug fix for an earlier error. Closes #1248

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1249.org.readthedocs.build/en/1249/

@github-actions github-actions bot added the bug Something isn't working label Dec 2, 2024
@wd60622 wd60622 requested review from lucianopaz and removed request for fonnesbeck December 2, 2024 11:20
@wd60622
Copy link
Contributor Author

wd60622 commented Dec 2, 2024

Ignore @fonnesbeck . Sorry

Copy link
Contributor

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wd60622!

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.64%. Comparing base (1464354) to head (e51364f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          39       39           
  Lines        4089     4091    +2     
=======================================
+ Hits         3911     3913    +2     
  Misses        178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622 wd60622 merged commit 1d89f66 into main Dec 2, 2024
13 checks passed
@wd60622 wd60622 deleted the 1248-pymc_marketingpriorhandle_dims-does-not-raise-an-error-when-dims-has-undesired-dimensions branch December 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prior class tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pymc_marketing.prior.handle_dims does not raise an Error when dims has undesired dimensions
3 participants