Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimal dependency PyMC >= 5.16 #1241

Closed
wants to merge 2 commits into from
Closed

Bump minimal dependency PyMC >= 5.16 #1241

wants to merge 2 commits into from

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Nov 26, 2024

Closes #726


📚 Documentation preview 📚: https://pymc-marketing--1241.org.readthedocs.build/en/1241/

@wd60622
Copy link
Contributor

wd60622 commented Nov 29, 2024

What's the reason for the upper bound at 5.19.0?

@juanitorduz
Copy link
Collaborator Author

What's the reason for the upper bound at 5.19.0?

Not strong opinions and we can remove it. I was thinking if 5.19.0 has other breaking changes that users are not faced with cryptic error messages. We can also make pymc-marketing releases more often that support every pymc major version update. WDYT?

@wd60622
Copy link
Contributor

wd60622 commented Nov 29, 2024

Not strong opinions and we can remove it. I was thinking if 5.19.0 has other breaking changes that users are not faced with cryptic error messages. We can also make pymc-marketing releases more often that support every pymc major version update. WDYT?

That'd be ideal so new pytensor can be used

@wd60622
Copy link
Contributor

wd60622 commented Nov 30, 2024

And wouldn't the test suite catch if the latest version of pymc is not working?

@juanitorduz
Copy link
Collaborator Author

Yes, but imagine another package or model in prod using pymc marketing. If they do not pin for a potential pymc breaking change then it will break their pipelines. Whereas if we have this is just a much more conservative approach. TBH, not strong opinion but this might motivate us to sync pathc releases with pymc

@juanitorduz
Copy link
Collaborator Author

See #1269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for PyMC 5.16 release
2 participants