Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beta ref mmm #1194

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix beta ref mmm #1194

merged 2 commits into from
Nov 14, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Nov 14, 2024

Closes #1191


📚 Documentation preview 📚: https://pymc-marketing--1194.org.readthedocs.build/en/1194/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM labels Nov 14, 2024
@juanitorduz
Copy link
Collaborator Author

I looked for beta_channel references in the repo and it seems we do not have more :)

@juanitorduz juanitorduz self-assigned this Nov 14, 2024
@juanitorduz juanitorduz removed the MMM label Nov 14, 2024
@juanitorduz juanitorduz requested a review from wd60622 November 14, 2024 14:05
@github-actions github-actions bot added the good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (94a8096) to head (ebbfb1b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          39       39           
  Lines        4064     4064           
=======================================
  Hits         3885     3885           
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz merged commit 0f68f90 into main Nov 14, 2024
14 checks passed
@juanitorduz juanitorduz deleted the beta-ref-mmm branch November 14, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change beta_channel references to saturation_beta in notebook
2 participants