Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented geometry.regular_polygon #73

Merged
merged 9 commits into from
Sep 25, 2022
Merged

implemented geometry.regular_polygon #73

merged 9 commits into from
Sep 25, 2022

Conversation

Emc2356
Copy link
Collaborator

@Emc2356 Emc2356 commented Sep 16, 2022

No description provided.

itzpr3d4t0r
itzpr3d4t0r requested changes Sep 17, 2022
View reviewed changes
geometry.pyi Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
itzpr3d4t0r
itzpr3d4t0r reviewed Sep 17, 2022
View reviewed changes
src_c/polygon.c Outdated Show resolved Hide resolved
@itzpr3d4t0r itzpr3d4t0r added type:new_api Adds new functionalities to the project submodule:polygon labels Sep 17, 2022
itzpr3d4t0r
itzpr3d4t0r reviewed Sep 18, 2022
View reviewed changes
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
src_c/polygon.c Outdated Show resolved Hide resolved
itzpr3d4t0r
itzpr3d4t0r approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@itzpr3d4t0r itzpr3d4t0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't check the tests tho, so i'll leave it to someone else

@novialriptide
Copy link
Member

I'm unsure about this PR because of its API design. Should we create a new constructor for Polygon instead of using a static method?

@itzpr3d4t0r
Copy link
Member

Let's pause a sec on this one, might be wise to implement this as a constructor

@novialriptide
Copy link
Member

novialriptide commented Sep 20, 2022 •
edited
Loading

See #82 for more info.

@novialriptide novialriptide mentioned this pull request Sep 20, 2022
Open
@Emc2356 Emc2356 changed the title implemented Polygon.normal_polygon implemented geometry.regular_polygon Sep 23, 2022
itzpr3d4t0r
itzpr3d4t0r reviewed Sep 25, 2022
View reviewed changes
src_c/geometry.c Outdated Show resolved Hide resolved
itzpr3d4t0r
itzpr3d4t0r reviewed Sep 25, 2022
View reviewed changes
src_c/geometry.c Outdated Show resolved Hide resolved
itzpr3d4t0r
itzpr3d4t0r reviewed Sep 25, 2022
View reviewed changes
src_c/geometry.c Outdated Show resolved Hide resolved
@itzpr3d4t0r itzpr3d4t0r merged commit 7105d34 into main Sep 25, 2022
@itzpr3d4t0r itzpr3d4t0r deleted the Polygon-normal_polygon branch September 26, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itzpr3d4t0r itzpr3d4t0r itzpr3d4t0r approved these changes

Assignees
No one assigned
Labels
dont-merge submodule:polygon type:new_api Adds new functionalities to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Emc2356 @novialriptide @itzpr3d4t0r