Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't truncate numpy array dimensions below max #792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexmojaki
Copy link
Contributor

The line half = min(shape[dimension], NUMPY_DIMENSION_MAX_SIZE) // 2 meant that when shape[dimension] was an odd number less than NUMPY_DIMENSION_MAX_SIZE, a single slice would be removed from the middle.

Also upgraded dependencies, mostly to allow formatting with ruff when using inline-snapshot. This caused some changes due to upgrading ruff and pyright.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (46d54a9) to head (d767bfa).

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #792    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          138       138            
  Lines        11013     11020     +7     
  Branches       781      1565   +784     
==========================================
+ Hits         11013     11020     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki requested a review from Kludex January 10, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant