Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(venue): add sign on moreInfo #548

Merged
merged 5 commits into from
Jun 30, 2024
Merged

fix(venue): add sign on moreInfo #548

merged 5 commits into from
Jun 30, 2024

Conversation

SivanYeh
Copy link
Collaborator

Types of changes

  • Bugfix

Description

希望增加※在更多資訊前

image

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit a0243a6
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66816483a90d6a00082222c1
😎 Deploy Preview https://deploy-preview-548--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit a0243a6
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66816483d1f6b00008ee2371
😎 Deploy Preview https://deploy-preview-548--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SivanYeh SivanYeh requested a review from mattwang44 June 27, 2024 09:46
Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我就整頁都檢查一遍:

  • 標點符號 nitpicking
    • 英文頁面上有出現全形括號(應該改半形)和中式全形頓號(應改成 ,
    • 英文頁面上半形括號與英文字詞之間應該留空格
  • 某些連結是有英文版的,切換成英文時可以也切換成英文頁面的連結,像是科工館YouBike 連結
  • i18n.js 裡面沒有用到的資訊有沒有需要清掉(或者備註一下現在沒用但以後用得到)?
  • 這個應該要改掉?
image

@SivanYeh
Copy link
Collaborator Author

我就整頁都檢查一遍:

  • 標點符號 nitpicking

    • 英文頁面上有出現全形括號(應該改半形)和中式全形頓號(應改成 ,
    • 英文頁面上半形括號與英文字詞之間應該留空格
  • 某些連結是有英文版的,切換成英文時可以也切換成英文頁面的連結,像是科工館YouBike 連結

  • i18n.js 裡面沒有用到的資訊有沒有需要清掉(或者備註一下現在沒用但以後用得到)?

  • 這個應該要改掉?

image

先修掉了第一點跟第四點.
礙於時限這張頁面可能需要先上了-> 第二跟第三部署後我再接續處理

@SivanYeh SivanYeh merged commit 61c032c into main Jun 30, 2024
9 checks passed
@SivanYeh SivanYeh deleted the fix/venue-update branch June 30, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants