Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proposal): change poster-session submit date UI #546

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

mhsiungw
Copy link
Contributor

@mhsiungw mhsiungw commented Jun 16, 2024

Types of changes

  • Update UI
    Screenshot 2024-06-16 at 23 16 12

DEMO

Screenshot 2024-06-16 at 23 11 42
Screenshot 2024-06-16 at 23 11 46

Steps to Test This Pull Request

Go to the path /speaking/poster-session

@mhsiungw mhsiungw requested a review from SivanYeh June 16, 2024 15:17
Copy link

netlify bot commented Jun 16, 2024

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit 846b5fe
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66700e277b55870008536a0e
😎 Deploy Preview https://deploy-preview-546--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 16, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit 846b5fe
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66700e27f36edd00080a09bf
😎 Deploy Preview https://deploy-preview-546--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SivanYeh
Copy link
Collaborator

@mhsiungw AoE連結再更新完就沒問題了~
這是新的6/30連結:
https://www.timeanddate.com/worldclock/converter.html?iso=20240701T115900&p1=tz_aoe&p2=241&p3=1440

@SivanYeh
Copy link
Collaborator

SivanYeh commented Jun 17, 2024

(just some nice-to-have) btw PR, commits的寫法可以參考這一篇文章:
https://www.conventionalcommits.org/en/v1.0.0/

以這次PR為例可以這樣寫:
PR title:
feat(proposal): change poster-session submit date UI

commit:
feat(proposal): update submit date in poster-session' s i18n

在PR介紹裡面除了Types of changes外, 可以新增簡短的測試方式:
例如:

Steps to Test This Pull Request

Go to the path /speaking/poster-session

@mhsiungw mhsiungw changed the title [feat] change poster-session submit date UI feat(proposal): change poster-session submit date UI Jun 17, 2024
@mhsiungw
Copy link
Contributor Author

(just some nice-to-have) btw PR, commits的寫法可以參考這一篇文章: https://www.conventionalcommits.org/en/v1.0.0/

以這次PR為例可以這樣寫: PR title: feat(proposal): change poster-session submit date UI

commit: feat(proposal): update submit date in poster-session' s i18n

在PR介紹裡面除了Types of changes外, 可以新增簡短的測試方式: 例如:

Steps to Test This Pull Request

Go to the path /speaking/poster-session

@SivanYeh 沒問題,已針對建議修改!

@SivanYeh
Copy link
Collaborator

LGTM!

@SivanYeh SivanYeh merged commit 5a22b61 into main Jun 18, 2024
9 checks passed
@SivanYeh SivanYeh deleted the feat/change-poster-session-submit-date-UI branch June 18, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants