Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #430: Validate an artifact using "hash" rather than "fileName" #851

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes #430: Validate an artifact using "hash" rather than "fileName" #851

wants to merge 3 commits into from

Commits on Dec 12, 2023

  1. Fixes pycontribs#430: Validate an artifact using "hash" rather than "… 

    …fileName"

Jenkins only stores one version of an artifact by its hash and by the
original filename.  Subsequent stores of an artifact with an identical
hash but different filename will point to the original artifact.  If a
duplicate artifact (identical hash) has a different filename than the
original filename then that new filename will be stored as a name in
the build artifacts but will not change the fileName of the original
artifact.  This makes it problematic to compare against the original
fileName when validating a build artifact that has been saved.

Since the md5sum hash is computed for the local, saved artifact it can
be compared against the Jenkins artifact ID (viz hash) for validation.
This avoids the problem of identical artifacts having additional
filenames.  Using the hash is also a better way of validating data
integrity rather than using the fileName even when the filename
matches.
    @plastikos
    plastikos committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5163a39 View commit details
    Browse the repository at this point in the history

  2. Change to log-style argument passing. 

    This updates an invocation of log.info() to use %-format style and
quells a Codacy complaint.
    @plastikos
    plastikos committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7c0a605 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1e1708b View commit details
    Browse the repository at this point in the history