Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pybind copts #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused pybind copts #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pybind11-BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ cc_library(
":msvc_compiler": [],
"//conditions:default": [
"-fexceptions",
# Useless warnings
"-Xclang-only=-Wno-undefined-inline",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never seen this style of flags before. Maybe these are specific to Google's internal complete wrapper and required to get parse_headers to pass with it?

"-Xclang-only=-Wno-pragma-once-outside-header",
"-Xgcc-only=-Wno-error", # no way to just disable the pragma-once warning in gcc
],
}),
includes = ["include"],
Expand Down