Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue #133 with string separation #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed Issue #133 with string separation #15

wants to merge 1 commit into from

Conversation

da4089
Copy link

@da4089 da4089 commented Feb 23, 2024

Fixes the behaviour of adding ; to strings in ORG field

Issue skarim#133
PR skarim#134

@otrekw
Fixed Issue skarim#133 with string separation
dfdafcd 
Fixes the behaviour of adding ; to strings in ORG field
@da4089 da4089 added this to the v1.0 milestone Mar 19, 2024
htgoebel
htgoebel suggested changes Jan 2, 2025
View reviewed changes
Copy link

@htgoebel htgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't refer to a issue number in the first line of a commit message. The first line should explain the commit.

Suggestion:

Fix adding ; between all chars when serializing a string.

See https://github.com/skarim/vobject/issues/133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htgoebel htgoebel htgoebel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.8
Development

Successfully merging this pull request may close these issues.
4 participants
@da4089 @hildigerr @htgoebel @otrekw