Fixes: IndexError while using split_text #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snanda85 Thanks for your pr, can you rebase with master? Can you Please remove the commit with the version bumps, or put them in a separate pr? |
bosd
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
LGTM 👍
Thanks for contibuting.
This bug has been open since 2019!
camelot-dev#98 and camelot-dev#99
Will merge this soon! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split_text in lattice mode raised IndexError in certain scenarios where empty TextLine exists (most likely in cases with multiline columns).
See camelot-dev#287 for more details.
This PR adds the fix provided by ramSeraph