Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme color dark support #4235

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Theme color dark support #4235

merged 4 commits into from
Aug 22, 2023

Conversation

khmyznikov
Copy link
Contributor

Support themeColorDark for Android CloudAPK.
Minor fix: app name regexp pattern browser error.

Need to merge the CloudAPK itself first: pwa-builder/CloudAPK#120

@khmyznikov khmyznikov requested a review from jgw96 August 8, 2023 11:18
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4235.centralus.2.azurestaticapps.net

@microsoft-github-policy-service
Copy link
Contributor

Thanks khmyznikov for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Contributor

@zateutsch zateutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks for dragging out that constant too

Copy link
Contributor

@jgw96 jgw96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice clean code Gleb

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4235.centralus.2.azurestaticapps.net

@khmyznikov khmyznikov added this pull request to the merge queue Aug 22, 2023
Merged via the queue into staging with commit 6aa5ff8 Aug 22, 2023
3 checks passed
@khmyznikov khmyznikov deleted the gleb/theme-color-dark branch August 22, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants