Improved string shortening for CJK languages. #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are trying to trim a string that contains CJK characters or even a string of western characters that don't have any spaces, then the entire string is stripped.
This pull request adds two bits of functionality:
Break words using spaces, dashes, zero-width space characters, and other standard word-break characters that work in most modern browsers.
If no word-break is found in the string, fall back to letter removal.
There are a few other minor js lint cleanups (trailing whitespace, empty line at end of file) that my editor cleaned up automatically and included in this commit as well.
Here are two fiddles that demonstrate the issue, and the fix: and the second with the patched code.
jquery.autoellipsis version 1.0.10 without the patch
http://jsfiddle.net/jwilson3/XKN9R/1/
jquery.autoellipsis with the patch applied in commit 0298b42
http://jsfiddle.net/jwilson3/XKN9R/3/