Feature/863 Objektive Abschluss Kommentar anzeigen #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miguel7373
force-pushed
the
feature/863-show-objective-completed-comment
branch
from
a57376a to
bfb9128
Compare
4 tasks
peggimann
requested changes
Jan 8, 2025
backend/src/main/java/ch/puzzle/okr/service/authorization/CompletedAuthorizationService.java
Outdated
Show resolved
Hide resolved
…tter spacing to frontend
…ic in the frontend
Miguel7373
force-pushed
the
feature/863-show-objective-completed-comment
branch
from
694ef76 to
c259a49
Compare
|
kcinay055679
requested changes
Jan 9, 2025
| @DisplayName("get() should throw exception when Completed with id cant be found") | ||
| @Test | ||
| void getShouldThrowExceptionWhenCompletedWithIdCantBeFound() throws Exception { | ||
| doThrow(new ResponseStatusException(HttpStatus.NOT_FOUND, "Completed not found")) |
There was a problem hiding this comment.
You are throwing an exception using mockito and then you just verify that this exception is thrown.
But this behavior doesnt occur while testing locally, you are just getting an 401 or a 500.
Try to just return null or smth like that from the persistenceservice and let your code handle it by itself
| @@ -48,6 +54,15 @@ export class ObjectiveDetailComponent implements OnInit { | |||
| .subscribe((objective) => this.objective$.next(objective)); | |||
| } | |||
|
|
|||
| loadComponent(id: number): void { | |||
| this.completedService | |||
| .getCompleted(id) | |||
There was a problem hiding this comment.
Don't load the completed all the time.
You get an error if the objective isnt completet
| id: 6, | ||
| version: 1, | ||
| title: 'titleWriteableFalse', | ||
| description: 'descriptionWriteableFalse', | ||
| teamId: 2, | ||
| quarterId: 2, | ||
| quarterLabel: 'GJ 22/23-Q2', | ||
| state: State.NOTSUCCESSFUL, | ||
| state: 'NOTSUCCESSFUL', |
| isWriteable: true | ||
| }; | ||
|
|
||
| export const objectiveWriteableFalse: Objective = { | ||
| export const objectiveWriteableFalse: any = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.