-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail upon encountering unrecognized fields when parsing config structures #697
Fail upon encountering unrecognized fields when parsing config structures #697
Conversation
spago.lock
Outdated
- variant | ||
test_dependencies: | ||
- spec | ||
core: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also regenerate the lockfile using spago 0.93.19
@thomashoneyman could we revert this one? We are introducing strict parsing of the @fsoikin if the intention is to support purescript/spago#1165 then we don't need any of these changes: the Spago config only needs strict record parsing for the |
Ah, I was just thinking about backwards compatibility. We can revert. |
The |
I think we should let the registry do its thing and just have the strict codecs we need in spago itself - the codecs don't need to be colocated with the types |
But then |
Could be n misspelled |
We can use strict codecs in spago and avoid the typos, but we should just duplicate the codec there instead of changing this one. We don't have the same forwards compatibility concerns in spago itself (we do have some, but just for a subset of the config file) |
Ah, I see the constructors are exported. Somehow I thought they weren't, similar to |
Fixes purescript/spago#1165