Update from deprecated aws-sdk bindings

[thomashoneyman]

Fixes #629. I manually verified that the inputs (params we pass to the s3 object) and outputs (data we receive) are unchanged in the new SDK, but I haven't actually run this code against our live bucket because the giant legacy importer run is going.

[thomashoneyman]

This is the only visible change to the requests based on our integration test and I think it's harmless, but without verifying against the actual bucket I can't be completely sure.

[f-f]

If it's generated by the new sdk then it's probably the right thing 😄

[f-f]

Ah, this looks way more straightforward than the last time I tried it 😅

[f-f]

If it's generated by the new sdk then it's probably the right thing 😄

[f-f]

Now that you're also online we can merge this and eventually revert it real quick if it's broken 😄

[thomashoneyman]

I was actually putting together a little script to upload, download, and delete an object in storage to be sure before I merge :) Let me give that a quick try and if it works I'll merge! I'll need about 1.5hrs before I can do it.

[f-f]

Ah that's lovely, thank you 🙂

[thomashoneyman]

Ran this script to test things out, with a tarball at delete-me-1.0.0 locally:

ain :: Effect Unit
main = launchAff_ do
  -- Environment
  _ <- Env.loadEnvFile ".env"
  resources <- Env.lookupResourceEnv
  s3 <- lift2 { key: _, secret: _ } (Env.lookupRequired Env.spacesKey) (Env.lookupRequired Env.spacesSecret)

  let
    cache = Path.concat [ scratchDir, ".cache" ]

    work = do
      Storage.upload (unsafePackageName "delete-me") (unsafeVersion "1.0.0") (Path.concat [ scratchDir, "delete-me-1.0.0" ])
      versions <- Storage.query (unsafePackageName "delete-me")
      Console.log $ "Versions (uploaded): " <> String.joinWith ", " (map Version.print (Set.toUnfoldable versions))
      Storage.download (unsafePackageName "delete-me") (unsafeVersion "1.0.0") (Path.concat [ scratchDir, "delete-me-2.0.0" ])
      Storage.delete (unsafePackageName "delete-me") (unsafeVersion "1.0.0")
      versions2 <- Storage.query (unsafePackageName "delete-me")
      Console.log $ "Versions (deleted): " <> String.joinWith ", " (map Version.print (Set.toUnfoldable versions2))

  work
    # Storage.interpret (Storage.handleS3 { s3, cache })
    # Log.interpret (Log.handleTerminal Verbose)
    # Except.catch (\e -> Run.liftEffect (Console.log e *> Process.exit 1))
    # Env.runResourceEnv resources
    # Run.runBaseAff'

This works just fine with the v2 of aws-sdk:

Read file for [email protected], now uploading to delete-me/1.0.0.tar.gz...
Connecting to the bucket purescript-registry at space https://ams3.digitaloceanspaces.com with public key YMQJ24GQQ2ZOGFXZWVQB
Connected to S3!
Uploading release to the bucket at path delete-me/1.0.0.tar.gz
Uploaded [email protected] to the bucket at path delete-me/1.0.0.tar.gz
Connecting to the bucket purescript-registry at space https://ams3.digitaloceanspaces.com with public key YMQJ24GQQ2ZOGFXZWVQB
Connected to S3!
Versions (uploaded): 1.0.0
Deleting [email protected]
Connecting to the bucket purescript-registry at space https://ams3.digitaloceanspaces.com with public key YMQJ24GQQ2ZOGFXZWVQB
Connected to S3!
Deleting release from the bucket at path delete-me/1.0.0.tar.gz
Deleted release of [email protected] from S3 at the path delete-me/1.0.0.tar.gz
Connecting to the bucket purescript-registry at space https://ams3.digitaloceanspaces.com with public key YMQJ24GQQ2ZOGFXZWVQB
Connected to S3!
Versions (deleted):

However, it turns out that the Contents key is now optional in the response; with that fixed this PR works as well.