Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node deps to breaking changes #671

Merged
merged 13 commits into from
Nov 30, 2023
Merged

Conversation

JordanMartinez
Copy link
Contributor

Currently fails with these errors when I call spago build. I didn't look into the 2nd/3rd error because I'm blocked by the first one:

[1/3 TypesDoNotUnify] .spago/packages/spago-core/47b735c5845a084f40826ae1989c3dc6c9171f21/core/src/Log.purs:161:23

  161    Effect.liftEffect $ Process.exit 1
                             ^^^^^^^^^^^^^^

  Could not match type
    Effect
  with type
    Function Int
  while trying to match type Effect t1
    with type Int -> t2
  while checking that expression exit 1
    has type Effect t0
  in value declaration die'
  where t0 is an unknown type
        t1 is an unknown type
        t2 is an unknown type

[2/3 TypesDoNotUnify] app/src/Fetch/Retry.purs:73:51

  73    coreResponse <- Promise.Aff.toAffE $ Core.fetch request
                                                        ^^^^^^^

  Could not match type
    Request
  with type
    Request
  while checking that type Request
    is at least as general as type Request
  while checking that expression request
    has type Request
  in value declaration fetch

[3/3 TypesDoNotUnify] foreign/src/Foreign/Gzip.purs:27:19

  27    toRequestBody = gzipToRequestBody
                        ^^^^^^^^^^^^^^^^^

  Could not match type
    RequestBody
  with type
    RequestBody
  while checking that type Gzip -> RequestBody
    is at least as general as type t0 -> RequestBody
  while checking that expression gzipToRequestBody
    has type t0 -> RequestBody
  where t0 is an unknown type

           Src   Lib   All
Warnings     0     0     0
Errors       2     1     3

❌ Failed to build.

@thomashoneyman
Copy link
Member

@JordanMartinez this should be unblocked now (no more spago-core dependency)

@JordanMartinez
Copy link
Contributor Author

Yup! Thanks!

@JordanMartinez
Copy link
Contributor Author

CI builds!

spago.yaml Outdated Show resolved Hide resolved
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than removing fetch from extra_packages, looks good to me!

@thomashoneyman thomashoneyman merged commit d7d35c9 into master Nov 30, 2023
15 checks passed
@thomashoneyman thomashoneyman deleted the jam/update-node-deps branch November 30, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants