Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qualified do notation where relevant #88

Merged
merged 3 commits into from
Sep 7, 2019

Conversation

JordanMartinez
Copy link
Contributor

Builds off of #86 and uses new purescript-indexed-monad release, which includes a file for qualified do, to remove the writeStatus :*> closeHeaders style of code for normal do notation via qualified do notation.

@nsaunders
Copy link
Contributor

Thanks for the PR. FYI: Hyper.Middleware.QualifiedDo

@JordanMartinez
Copy link
Contributor Author

I'm aware of that file, but I thought it odd that such a file existed here rather than in the purescript-indexed-monads library, where it seemed more appropriate.

@JordanMartinez
Copy link
Contributor Author

With #86 closed, is this change desired if I rebased it?

@nsaunders
Copy link
Contributor

Indeed, I think it's a reasonable change. 👍

@JordanMartinez
Copy link
Contributor Author

Done.

@nsaunders nsaunders merged commit 6eb9617 into purescript-hyper:master Sep 7, 2019
@nsaunders
Copy link
Contributor

Thanks @JordanMartinez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants