-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Menu #424
Merged
Merged
New Menu #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes .pure-menu smaller, more responsive, and easier to customize. - Remove `.pure-menu-open` - Remove dropdown menu CSS - Add `.pure-menu-responsive` and `.pure-menu-toggle` to make responsive horizontal menus. - Make pure menus *really* easy to customize
- Removed menus-paginator, I don't think it's very useful - Added CSS-only dropdowns - Mobile-first - Easier to style, with new classnames - Responsive Menus supported
Conflicts: src/menus/css/menus-core.css src/menus/tests/manual/menus.html
…ue border just fine.
…l rule ensures the caret :after for a dropdown menu does not affect the sizing of its parent box, which was causing bad vertical alignment of links in the horizontal menu.
CLA is valid! |
This was referenced Jan 21, 2015
Closed
Closed
… in a scrollable concept. Everything has been designed to work well with the new JS I've written which adds in better accessibility. More to come though.
…inue to work on the examples...
…d to developing the menus.js file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly revises Tilo Mitra's second take on Menus. I significantly reworked everything and cooked up new examples and tests. Tilo's core insight has been retained: that lower-specificity selectors via additional classnames will make customization easier.
Pros:
More responsive, with the inclusion of horizontal responsive menus.This feature has been removed from the version currently in development. It was not accessible and was rather opinionated and clunky. Sorry, but I had to jettison the concept. However, I added new responsive menu examples to the Layouts page.pure-menu-allow-hover
class will enable menus which reveal on hover, which is sometimes desirable and a nice way to handle the no-JS case.pure-menu-scrollable
class to make your menu scrollable and flickable when there isn't enough room to display the whole thing.Cons:
How to Upgrade:
pure-menu-open
class. It's not used anymore.pure-menu-list
to your menu's<ul>
.pure-menu-item
to any<li>
.pure-menu-link
to any<a>
..pure-menu > li > a { ... }
) may still work, since the overall markup structure has not changed. Consider addingpure-menu-custom-foo
classes and writing your customizations on top of them instead of modifying Pure's classes.pure-menu-item
andpure-menu-link
padding to suit your design.