(maint) make service test less sensitive #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service test contained a regular expression that matched on the size of the content. The headers that are included in the response depend on the platform and java version that are used to run the tests, so this removes the size part of the regular expression to make the tests less sensitive to environment. The underlying behavior in the test isn't impacted; it still validates that the logging occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service test contained a regular expression that matched on the size of the content. The headers that are included in the response depend on the platform and java version that are used to run the tests, so this removes the size part of the regular expression to make the tests less sensitive to environment. The underlying behavior in the test isn't impacted; it still validates that the logging occurred.