Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore changelog of < 2.10.0 #83

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

ekohl
Copy link

@ekohl ekohl commented Oct 17, 2023

Fixes: fab98f3 ("Release prep v3.0.0-rc.1")

@ekohl ekohl requested review from bastelfreak and a team as code owners October 17, 2023 17:59
Fixes: fab98f3 ("Release prep v3.0.0-rc.1")
@jordanbreen28
Copy link

hey @ekohl - thanks for this!
It's worth noting that the changelog generator we use will overwrite the changes in CHANGELOG.md when run again (it has no HISTORY.md support as of yet either..), but I appreciate your efforts in assigning the older missing entries into a HISTORY.md.
This should help to cover the missing changelog entries until (or if) we get history.md supported added to the changelog generator.

@jordanbreen28 jordanbreen28 merged commit 1a5fd2e into puppetlabs:main Oct 18, 2023
7 checks passed
@ekohl ekohl deleted the restore-changelog branch October 18, 2023 10:00
@ekohl
Copy link
Author

ekohl commented Oct 18, 2023

Ah, you're not using GitHubChangelogGenerator anymore?

@jordanbreen28
Copy link

@ekohl unfortunately not, we made the jump to gh-changelog as we were encountering issues with github_changelog_generator 👎 For now, I re-added your entries back in when they were overwritten in #84 as they are really nice to have.
Might be something we try to implement as a feature on gh-changelog to add HISTORY.md support, which would be a big plus. Give us a chance to brush up on the go skills 💯

@jordanbreen28
Copy link

@ekohl
Copy link
Author

ekohl commented Oct 18, 2023

I've also seen plenty of issues with GitHubChangelogGenerator so I'm not particularly attached to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants