Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CAT-836) - Bump Jquery to 3.7.1 & Bootstrap 5.3.2 #72

Merged
merged 8 commits into from
Oct 2, 2023
Merged

(CAT-836) - Bump Jquery to 3.7.1 & Bootstrap 5.3.2 #72

merged 8 commits into from
Oct 2, 2023

Conversation

jordanbreen28
Copy link

@jordanbreen28 jordanbreen28 commented Sep 29, 2023 •
edited
Loading

Summary

This PR bumps the version of jQuery used to 3.7.1 (latest) and Bootstrap 5.3.2 (latest).
Removes the unused examples directory.
Removes the unused demo files.
Removes bootstrap-theme files, as these were made obselete in bootstrap v4.x+. (see here).

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 changed the title (CAT-836) - Bump Jquery to 3.7.1 & Bootstrap 4.1.3 (CAT-836) - Bump Jquery to 3.7.1 & Bootstrap 4.3.1 Sep 29, 2023
ekohl
ekohl suggested changes Sep 29, 2023
View reviewed changes
Copy link

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes to docs/_layouts/base.html and docs/_layouts/cards.html which are the actual files that reference the jquery files.

docs/assets/plugins/jquery-scrollTo/demo/index.old.html Outdated Show resolved Hide resolved
docs/assets/plugins/lightbox/examples/index.html Outdated Show resolved Hide resolved
@jordanbreen28 jordanbreen28 marked this pull request as draft September 29, 2023 10:00
@jordanbreen28
(CAT-836) - Update to Jquery 3.7.1
5feb850 
(CAT-836) - Update to Jquery 3.7.1
@jordanbreen28 jordanbreen28 force-pushed the CAT-836-update_bootstrap_jquery branch 2 times, most recently from 0138677 to 64a636a Compare September 29, 2023 10:37
@jordanbreen28 jordanbreen28 changed the title (CAT-836) - Bump Jquery to 3.7.1 & Bootstrap 4.3.1 (CAT-836) - Bump Jquery to 3.7.1 & Bootstrap 5.3.2 Sep 29, 2023
@jordanbreen28 jordanbreen28 marked this pull request as ready for review October 2, 2023 08:05
@GSPatton GSPatton merged commit 451429d into main Oct 2, 2023
6 checks passed
@GSPatton GSPatton deleted the CAT-836-update_bootstrap_jquery branch October 2, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

@GSPatton GSPatton GSPatton approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanbreen28 @ekohl @GSPatton