add test to cover basic server configuration #1534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHoenscheid
requested review from
alexjfisher,
bastelfreak,
deric,
ekohl,
smortex and
a team
as code owners
SimonHoenscheid
force-pushed
the
missing_key_acceptance_test
branch
from
a909a58 to
784db20
Compare
ekohl
reviewed
Oct 18, 2023
| include postgresql::server | ||
| MANIFEST | ||
| it 'installs postgres' do | ||
| apply_manifest(pp, catch_failures: true) |
There was a problem hiding this comment.
Should it run a second time (with catch_changes: true instead) as an idempotency check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
create test to cover #1533 behaviour
Checklist
puppet apply)