Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trailing spaces #412

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix trailing spaces #412

merged 1 commit into from
Dec 12, 2023

Conversation

vchepkov
Copy link
Contributor

@vchepkov vchepkov commented Dec 7, 2023

Summary

@example tag requires a description, otherwise puppet-strings leaves trailing spaces

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@vchepkov vchepkov requested review from a team as code owners December 7, 2023 20:43
@vchepkov
fix trailing spaces
dd0f740 
@example tag requires a description, otherwise puppet-strings leaves trailing spaces
@vchepkov
Copy link
Contributor Author

vchepkov commented Dec 7, 2023

There is also empty line added at the end of REFERENCE.md due to this line, imho
https://github.com/puppetlabs/puppet-strings/blob/main/lib/puppet-strings/markdown/templates/data_type.erb#L91

@ragingra ragingra merged commit 770f8a1 into puppetlabs:main Dec 12, 2023
49 checks passed
@vchepkov vchepkov deleted the fix-examples branch December 14, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@ragingra ragingra ragingra approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vchepkov @bastelfreak @ragingra @cathal41