agent_state_summary: Properly handle nodes without reports/responses #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, when running `pe_status_check::agent_state_summary`, the
result didn't only contain the certnames, but also additional data:`
without this patch (one unresponsive node, one without reports at all):
```json
{
"noop": [
],
"corrective_changes": [
],
"used_cached_catalog": [
],
"failed": [
],
"changed": [
],
"unresponsive": [
{
"certname": "pe.tim",
"latest_report_noop": false,
"latest_report_corrective_change": false,
"cached_catalog_status": "not_used",
"latest_report_status": "unchanged",
"report_timestamp": "2024-12-05T13:41:55.483Z"
}
],
"no_report": [
"agent.tim"
],
"responsive": [
"pe.tim"
],
"unhealthy": [
{
"certname": "pe.tim",
"latest_report_noop": false,
"latest_report_corrective_change": false,
"cached_catalog_status": "not_used",
"latest_report_status": "unchanged",
"report_timestamp": "2024-12-05T13:41:55.483Z"
},
"agent.tim"
],
"unhealthy_counter": 2,
"healthy_counter": 1,
"total_counter": 2
}
```
To reproduce, do on the agent:
```
puppet ssl submit_request
puppet ssl download_cert
puppet facts upload
```
Now on the puppetserver:
```
puppet query nodes[certname,report_timestamp]{}
```
gives you:
```json
[
{
"certname": "pe.tim",
"report_timestamp": "2024-12-05T13:11:55.884Z"
},
{
"certname": "agent.tim",
"report_timestamp": null
}
]
```
with this patch:
```json
{
"noop": [
],
"corrective_changes": [
],
"used_cached_catalog": [
],
"failed": [
],
"changed": [
],
"unresponsive": [
"pe.tim"
],
"no_report": [
"agent.tim"
],
"responsive": [
],
"unhealthy": [
"pe.tim",
"agent.tim"
],
"unhealthy_counter": 2,
"healthy_counter": 0,
"total_counter": 2
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, when running
pe_status_check::agent_state_summary, the result didn't only contain the certnames, but also additional data:`without this patch (one unresponsive node, one without reports at all):
{ "noop": [ ], "corrective_changes": [ ], "used_cached_catalog": [ ], "failed": [ ], "changed": [ ], "unresponsive": [ { "certname": "pe.tim", "latest_report_noop": false, "latest_report_corrective_change": false, "cached_catalog_status": "not_used", "latest_report_status": "unchanged", "report_timestamp": "2024-12-05T13:41:55.483Z" } ], "no_report": [ "agent.tim" ], "responsive": [ "pe.tim" ], "unhealthy": [ { "certname": "pe.tim", "latest_report_noop": false, "latest_report_corrective_change": false, "cached_catalog_status": "not_used", "latest_report_status": "unchanged", "report_timestamp": "2024-12-05T13:41:55.483Z" }, "agent.tim" ], "unhealthy_counter": 2, "healthy_counter": 1, "total_counter": 2 }To reproduce, do on the agent:
Now on the puppetserver:
gives you:
[ { "certname": "pe.tim", "report_timestamp": "2024-12-05T13:11:55.884Z" }, { "certname": "agent.tim", "report_timestamp": null } ]with this patch:
{ "noop": [ ], "corrective_changes": [ ], "used_cached_catalog": [ ], "failed": [ ], "changed": [ ], "unresponsive": [ "pe.tim" ], "no_report": [ "agent.tim" ], "responsive": [ ], "unhealthy": [ "pe.tim", "agent.tim" ], "unhealthy_counter": 2, "healthy_counter": 0, "total_counter": 2 }Please check off the steps below as you complete each step
(SUP-XXXX) Add Super Duper State CheckReady for Reviewif there is one