Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SUP-4990) S0039 Accommodate parsing of unicode dates in September #234

Merged
merged 2 commits into from
Nov 14, 2024
Merged

(SUP-4990) S0039 Accommodate parsing of unicode dates in September #234

merged 2 commits into from
Nov 14, 2024

Conversation

EdwardBenton
Copy link
Contributor

@EdwardBenton EdwardBenton commented Sep 4, 2024 •
edited
Loading

Add string substitution to S0039 to accommodate unicode CLDR change from Sep to Sept for %b in September

Please check off the steps below as you complete each step

  • Put the Jira ticket or Github issue number in parentheses in the Title e.g. (SUP-XXXX) Add Super Duper State Check
  • Update the Jira ticket status to Ready for Review if there is one
  • Review any CI failures and fix issues

@EdwardBenton
Update pe_status_check.rb
5fc9fb3 
Add string substitution to S0039 to accommodate unicode CLDR change from Sep to Sept for %b in September
@EdwardBenton EdwardBenton requested a review from a team as a code owner September 4, 2024 12:20
@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@EdwardBenton EdwardBenton changed the title Update pe_status_check.rb (SUP-4990) S0039 Accommodate parsing of unicode dates in September Sep 4, 2024
@Aaronoftheages Aaronoftheages self-requested a review September 30, 2024 13:10
@Aaronoftheages
Copy link
Contributor

@EdwardBenton update the branch and I'll get that approved, so far it looks good to me.

@MartyEwings MartyEwings merged commit b4e1c50 into puppetlabs:main Nov 14, 2024
17 of 31 checks passed
@MartyEwings MartyEwings added the enhancement New feature or request label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartyEwings MartyEwings MartyEwings approved these changes

@Aaronoftheages Aaronoftheages Awaiting requested review from Aaronoftheages

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EdwardBenton @CLAassistant @Aaronoftheages @MartyEwings