Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aarch64 architecture in apt repo #898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

saz
Copy link

@saz saz commented Feb 15, 2023

dpkg expects arm64, while the kernel reports aarch64

#115 broke it on ARM. In #494 was this already pointed out.

dpkg expects `arm64`, while the kernel reports `aarch64`
@saz saz requested a review from a team as a code owner February 15, 2023 09:56
@puppet-community-rangefinder
Copy link

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and click the right button 😒

@saz
Copy link
Author

saz commented Feb 21, 2023

@smortex Mind restarting the failing test? It's not related to my change.

@smortex
Copy link
Collaborator

smortex commented Feb 22, 2023

Restarted it but CI setup seems broken:

Mandatory parameters apiKey/licenseKey were not set

I guess we can ignore this for now 🤷

@saz
Copy link
Author

saz commented Mar 26, 2023

Any news on this one? Anything I need to do?

@grzleadams
Copy link

Any updates on this?

@parkr
Copy link

parkr commented Jun 21, 2023

@smortex Hey, do you know anyone in @puppetlabs/modules who could take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With Ubuntu on arm64 apt/sources.list.d/docker.list specifies wrong architecture by default
6 participants