Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve param_changed detection (#881) #883

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve param_changed detection (#881) #883

wants to merge 2 commits into from

Commits on Mar 21, 2023

  1. Fixes puppetlabs#881 - docker mount comparison 

    This resolves issues identified around mount/volume comparisons for
non Windows based OSs. I assume the Windows variant has all the issues
found for 881 too but cannot verify/fix.

To resolve the issues, the mounts/volumes are turned into hashes and
the whole hash is compared versus trying to compare lists of keys. This
allows related parameters (source + dest) to be compared at the same time.

Signed-off-by: Ben Magistro <[email protected]>
    @bmagistro
    bmagistro committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    45114e8 View commit details
    Browse the repository at this point in the history

  2. Fixes puppetlabs#781 - docker port comparisons 

    This resolves issues identified around port comparison by mapping all related fields
into a hash and comparing the whole hash versus individual keys.

Signed-off-by: Ben Magistro <[email protected]>
    @bmagistro
    bmagistro committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3101b6f View commit details
    Browse the repository at this point in the history