(PA-5692) Build yaml-cpp and boost on Solaris 11 SPARC #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't find a way to to make solaris-11-sparc platform definition take into account the project, because of the way vanagon creates the Platform and then later the Project. So create a new solaris-113-sparc platform definition for native Solaris compiles. Since the name of the file contains 113, vanagon assumes that's the `os_version`. Setting the os_version from within the platform definition doesn't seem to work, so I had to specialy case some logic to check for the platform.name. Although we're native compiling on SPARC, we have to explicitly set `--with-baseruby=no` so that ruby's configure script does not attempt to use the ancient ruby already installed. Instead build miniruby and have the build use that. We should probably be setting `--with-baseruby=no` always, except in cases where we're cross compiling to avoid this same problem on other platforms. Similarly, ruby's configure script will attempt to enable `dtrace` because the executable is present. Explicitly disable it.
The ruby-augeas gem's native extensions didn't work, because we were overriding rbconfig when native compiling. It is only necessary to do that when cross compiling, because the host ruby running on Solaris Intel needs to override CC, etc configuration when installing gems with native extensions. The ruby-shadow gem did work on SPARC, but it was relying on the rbconfig overrides to find gcc. Instead add pl-build-tools to the PATH and only override rbconfig when cross compiling.
boost: no changes are required to build, so add the component. yaml-cpp: default to /usr/bin/gmake except for Solaris 10 and use /usr/bin/cmake instead of pl-cmake.
|
This only affects solaris 113 for
|
cthorn42
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost: no changes are required to build, so add the component.
yaml-cpp: default to /usr/bin/gmake except for Solaris 10 and use /usr/bin/cmake
instead of pl-cmake.
Successfully built in https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2229/BUILD_TARGET=solaris-113-sparc,SLAVE_LABEL=k8s-worker/ and shipped to https://builds.delivery.puppetlabs.net/puppet-runtime/cd2f8ed54cff954306835f71942e2fe1dd10d6f6/artifacts/