Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r10k: Require 4.x & octokit: Allow newer versions & puppetlabs_spec_helper: Require 7.x #3249

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

r10k: Require 4.x & octokit: Allow newer versions & puppetlabs_spec_helper: Require 7.x #3249

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d1655f
r10k: Require version 4
bastelfreak Nov 27, 2023
26d1949
octokit: Allow newer versions
bastelfreak Nov 27, 2023
11a2de4
puppetlabs_spec_helper: Require 7.x
bastelfreak Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bolt.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,15 @@ Gem::Specification.new do |spec|
spec.add_dependency "puppetfile-resolver", ">= 0.6.2", "< 1.0"
spec.add_dependency "puppet-resource_api", ">= 1.8.1"
spec.add_dependency "puppet-strings", ">= 2.3.0", "< 5.0"
spec.add_dependency "r10k", "~> 3.10"
spec.add_dependency "r10k", "~> 4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cant drop support for 3. We can update to support both 3 and 4 if that is helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I took a bit of a break in responding here because the whole Ruby situation in the Puppet/Perforce tooling is a bit frustrating.

In theory we could do spec.add_dependency "r10k", ">= 3.10", "< 5". But bundler showed in the past that it had some trouble to figure out correct versions / it didn't always hounor the minimal ruby version in the dependencies. I don't know if this keeps working on ruby 2.5 / 2.6 if we do the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec.add_dependency "r10k", ">= 3.10", "< 5" seems reasonable to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in order to actuallly use the new r10k version, we need a release of puppetlabs/orchestrator_client-ruby#38 .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

spec.add_dependency "ruby_smb", "~> 1.0"
spec.add_dependency "terminal-table", "~> 3.0"
spec.add_dependency "winrm", "~> 2.0"
spec.add_dependency "winrm-fs", "~> 1.3"

spec.add_development_dependency "bundler", ">= 1.14"
spec.add_development_dependency "octokit", "~> 4.0"
spec.add_development_dependency "puppetlabs_spec_helper", "~> 5.0"
spec.add_development_dependency "octokit", ">= 4.0", '< 9'
spec.add_development_dependency "puppetlabs_spec_helper", "~> 7.0", '>= 7.0.1'
spec.add_development_dependency "rake", "~> 12.0"
spec.add_development_dependency "rspec", "~> 3.0"
end
Loading