Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

Implement exec on Directories #772

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

sbrow
Copy link

@sbrow sbrow commented Apr 15, 2020

As discussed in issue #769. This is still a work in progress.

Todos:

  • Write tests
  • Implement in plugins other than docker.
  • Add option to enable in volume.NewFS?
  • Update entrySchema on execDir.

@welcome
Copy link

welcome bot commented Apr 15, 2020

Hi! 💖 Thanks for your contribution 🎉🥳

We'll get it reviewed as soon as possible. If you'd like to chat with the developers, the #puppet-dev channel on Slack would probably be a great place to start. Make sure that your commit messages fit our contribution standards to make the code review go quickly.

If this is your first contribution to our repositories, then we'd love to send you a small welcome gift 🎁. Drop us a line at [email protected] and let us know where to send it! (/cc @puppetlabs/community)

Currently works only for the docker plugin.

Signed-off-by: Spencer Brower <[email protected]>
@MikaelSmith
Copy link
Contributor

That looks pretty straightforward, although it looks like some test mocking needs to be tweaked.

Signed-off-by: Spencer Brower <[email protected]>
@MikaelSmith MikaelSmith changed the base branch from master to main July 15, 2020 15:58
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants