Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing exposed secret in webhook preview #370

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

IaroslavTitov
Copy link
Contributor

Summary

Added KeepSecrets where it was missing in marshaling logic, to make sure Webhook preview doesn't expose secrets.

Testing

  • Manually ran pulumi up -> details and verified it no longer shows up

@IaroslavTitov IaroslavTitov marked this pull request as ready for review August 6, 2024 19:25
@IaroslavTitov IaroslavTitov merged commit 4c52bda into main Aug 6, 2024
13 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/webhook_fix branch August 6, 2024 20:03
Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! Can we please check that:

@IaroslavTitov
Copy link
Contributor Author

IaroslavTitov commented Aug 6, 2024

Verified that refresh works fine (integ tests double checked me). The secret is not returned, so no issues with deserializing that.

  • We audit and open issues for other resources?

I tested other resources by taking all of out yaml examples, gluing together into one program, then replacing all strings with ${mySecret}. Ran pulumi preview -> details and the secret did not show up as plaintext, so this is not an issue for other resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants