Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a nil pointer deref #356

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix a nil pointer deref #356

merged 2 commits into from
Jul 19, 2024

Conversation

komalali
Copy link
Member

@komalali komalali commented Jul 19, 2024 •
edited
Loading

Password is not a required field, so it can be nil. We should first check if it's nil before checking its value.

Fixes #355

@komalali komalali requested a review from a team July 19, 2024 22:32
@komalali komalali enabled auto-merge (squash) July 19, 2024 22:36
@komalali komalali merged commit 33718a0 into main Jul 19, 2024
13 checks passed
@komalali komalali deleted the komal/fix-nil-deref branch July 19, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IaroslavTitov IaroslavTitov IaroslavTitov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation Violation using DeploymentSettings in v0.22.0
2 participants
@komalali @IaroslavTitov