Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing noisy diff in DS OIDC object #348

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fixing noisy diff in DS OIDC object #348

merged 1 commit into from
Jul 10, 2024

Conversation

IaroslavTitov
Copy link
Contributor

Summary

  • Fixed diff in azure object by actually adding it to the call - it was missed accidentally
  • Fixed diff in aws object's duration field by normalizing the string in Check method, the same way Pulumi Service does (conversion into time.Duration and back into string)
  • Removing SkipRefresh flag, now that DeploymentSettings are fully without diff

Testing

  • Manual test using TS program
  • Integ tests

@IaroslavTitov IaroslavTitov marked this pull request as ready for review July 3, 2024 22:50
komalali
komalali reviewed Jul 9, 2024
View reviewed changes
provider/pkg/provider/deployment_settings.go
@@ -236,6 +237,7 @@ func (ds *PulumiServiceDeploymentSettingsInput) ToPropertyMap(plaintextInputSett
if ds.OperationContext.OIDC.Azure.SubscriptionID != "" {
azureMap["subscriptionId"] = resource.NewPropertyValue(ds.OperationContext.OIDC.Azure.SubscriptionID)
}
oidcMap["azure"] = resource.PropertyValue{V: azureMap}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe whoops

@IaroslavTitov IaroslavTitov merged commit 7d42451 into main Jul 10, 2024
14 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/oidc branch July 10, 2024 16:02
@IaroslavTitov IaroslavTitov mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komalali komalali komalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IaroslavTitov @komalali