Expose GitHub team ID

[blampe]

The team creation API for GitHub teams only requires a githubTeamID parameter, which it uses to fetch all the other details like team name, description, members, etc.

I implemented Read while I was in here, because it was surprising to see this break refresh due to a not-implemented error. Also implemented Check because name and githubTeamId are only required for certain team types.

Tested and confirmed working by with the following program:

import * as pulumi from "@pulumi/pulumi";
import * as service from "@pulumi/pulumiservice";

const team = new service.Team("github-team", {
  organizationName: "pulumi",
  teamType: "github",
  githubTeamId: 7475955,
});

❯ pulumi up -s pulumi/test
Previewing update (pulumi/test)

View in Browser (Ctrl+O): https://.../pulumi/pulumi-service-teams-example-ts/test/previews/3dd36e22-e7d7-4b5d-82d0-2bbd8d61f86e

     Type                         Name                                  Plan
     pulumi:pulumi:Stack          pulumi-service-teams-example-ts-test
 +   └─ pulumiservice:index:Team  github-team                           create


Resources:
    + 1 to create
    1 unchanged

Do you want to perform this update? details
  pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:test::pulumi-service-teams-example-ts::pulumi:pulumi:Stack::pulumi-service-teams-example-ts-test]
    + pulumiservice:index:Team: (create)
        [urn=urn:pulumi:test::pulumi-service-teams-example-ts::pulumiservice:index:Team::github-team]
        [provider=urn:pulumi:test::pulumi-service-teams-example-ts::pulumi:providers:pulumiservice::default_0_9_1_alpha_1689717595_28bbd1fc_dirty::7a11ee03-f53f-4ebc-8c9f-a09cfe4ad07a]
        githubTeamId    : 7475955
        organizationName: "pulumi"
        teamType        : "github"

Do you want to perform this update? yes
Updating (pulumi/test)

View in Browser (Ctrl+O): https://.../pulumi/pulumi-service-teams-example-ts/test/updates/5

     Type                         Name                                  Status
     pulumi:pulumi:Stack          pulumi-service-teams-example-ts-test
 +   └─ pulumiservice:index:Team  github-team                           created (0.94s)


Resources:
    + 1 created
    1 unchanged

Duration: 3s

Fixes #151.

[lukehoban]

I believe some additional changes to the schema will be needed. Also would be great to add test coverage for this - though not sure how easy it will be to automate that end-to-end. At the very least - a test that runs a preview to ensure this is supported correctly in the generated SDK.

[lukehoban]

This needs to also be listed as an input property, right?

The schema still marks the other input properties as required, do those need to be made optional now?

[blampe]

The schema still marks the other input properties as required, do those need to be made optional now?

Updated so name is now optional, org and type are still needed to construct relevant URLs.

[pgavlin]

Do we validate the various combinations in Check?

[blampe]

@pgavlin doesn't seem like it https://github.com/pulumi/pulumi-pulumiservice/blob/main/provider/pkg/provider/team.go#L99-L101

Most of this provider's checks seem to no-op like this. If it's worth doing while we're in here I can implement it.

[pgavlin]

Most of this provider's checks seem to no-op like this

:(

If it's worth doing while we're in here I can implement it.

I think that it's worth doing in this case b/c there are different combinations of valid inputs depending on the team type.

[pgavlin]

LGTM, just one question about Check