Skip to content

Commit

Permalink
Removing accessToken defaults from schema to prevent leaks (#351)
Browse files Browse the repository at this point in the history
### Summary:
- This will prevent manually created provider resource from saving
EnvVar value into state file of the stack
- The default provider resource can still potentially leak accessToken
value, if it is specified in the config as plaintext (highly
non-advisable)

### Testing:
- Integ tests
- Manually tests
  • Loading branch information
IaroslavTitov authored Jul 17, 2024
1 parent be03184 commit a18c19b
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 21 deletions.
1 change: 1 addition & 0 deletions CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- Fixed import by refactoring Read method of AccessToken resource + minor refactor [#311](https://github.com/pulumi/pulumi-pulumiservice/issues/311)
- Fixed import by refactoring Read method of AgentPool resource + minor refactor [#311](https://github.com/pulumi/pulumi-pulumiservice/issues/311)
- Fixing noisy diff in DS OIDC object [#330](https://github.com/pulumi/pulumi-pulumiservice/issues/330)
- Removed accessToken provider parameter defaults from schema to prevent leaks [#350](https://github.com/pulumi/pulumi-pulumiservice/issues/350)

### Miscellaneous
- Added CHANGELOG_PENDING file to ignore-list of the `main` workflow [[#340](https://github.com/pulumi/pulumi-pulumiservice/issues/340)]
7 changes: 1 addition & 6 deletions provider/cmd/pulumi-resource-pulumiservice/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@
"accessToken": {
"description": "Access Token to authenticate with Pulumi Cloud.",
"type": "string",
"default": "",
"defaultInfo": {
"environment": [
"PULUMI_ACCESS_TOKEN"
]
}
"secret": true
}
}
},
Expand Down
15 changes: 12 additions & 3 deletions sdk/dotnet/Provider.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions sdk/go/pulumiservice/provider.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/nodejs/provider.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions sdk/python/pulumi_pulumiservice/provider.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a18c19b

Please sign in to comment.