Handles an exception for non-existing repository #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
reviewed
Jul 25, 2024
CHANGES/1703.bugfix
Outdated
Comment on lines
1
to
3
| Fixed an issue that triggered a `NoneType` exception during a GET request when | ||
| a `distribution` was created with only the `repository_version` (without specifying | ||
| a `repository`). |
There was a problem hiding this comment.
Suggested change
| Fixed an issue that triggered a `NoneType` exception during a GET request when | |
| a `distribution` was created with only the `repository_version` (without specifying | |
| a `repository`). | |
| Fixed an issue causing an HTTP 500 error when a GET request for a non-existing blob was made to a distribution with only a `repository_version` set. |
How about this? It does not talk about Python types. Users do not care about them.
Comment on lines
292
to
293
| with self.assertRaises(requests.exceptions.HTTPError): | ||
| content_response.raise_for_status() |
There was a problem hiding this comment.
Can we check that this returns 404 instead of 500?
git-hyagi
force-pushed
the
repo-blob-exception
branch
from
265be2f
to
56a40a3
Compare
lubosmj
approved these changes
Jul 25, 2024
Backport to 2.21: 💚 backport PR created✅ Backport PR branch: Backported as #1719 🤖 @patchback |
Backport to 2.20: 💚 backport PR created✅ Backport PR branch: Backported as #1720 🤖 @patchback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1703