Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the file extension of exports #1401

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix the file extension of exports #1401

merged 1 commit into from
Oct 13, 2023

Conversation

lubosmj
Copy link
Member

@lubosmj lubosmj commented Oct 12, 2023

[noissue]

@lubosmj
Copy link
Member Author

lubosmj commented Oct 12, 2023

This is trying to fix CI errors caused by pulp/pulpcore@c49624c.

@lubosmj lubosmj marked this pull request as draft October 12, 2023 16:57
@lubosmj lubosmj force-pushed the fix-ci-failures-extension-export-tar-gz branch from d915225 to 25c27c5 Compare October 12, 2023 17:33
@lubosmj lubosmj marked this pull request as ready for review October 12, 2023 17:33
mdellweg
mdellweg approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the sharp version dependent assertion.

But also i'm wondering, is it worth a test in pulp_container how the files are named? Is that maybe a pulpcore implementation detail we should not care about here?
Anyway, I'm approving.

@lubosmj
Copy link
Member Author

lubosmj commented Oct 13, 2023

To my knowledge, there is a limitation where we do not know the name of the exported tarball beforehand. That is the reason why this change was introduced in the first place. The same is done in pulp_rpm: https://github.com/pulp/pulp_rpm/blob/a1a3bdd051bdb263445a72bc4b652bec6db910fa/pulp_rpm/tests/functional/api/test_pulpimport.py#L269.

@lubosmj lubosmj merged commit 4df9e2e into main Oct 13, 2023
14 checks passed
@mdellweg mdellweg deleted the fix-ci-failures-extension-export-tar-gz branch October 13, 2023 08:55
@patchback Patchback
Copy link

patchback bot commented Dec 13, 2023 •
edited
Loading

Backport to 2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.16/4df9e2ebb20f4a48f6441fe2f11f7f98284c8a1c/pr-1401

Backported as #1449

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

@ipanova ipanova ipanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lubosmj @ipanova @mdellweg