Add pulp-ui to pulp image #677
Conversation
images/pulp/stable/Containerfile
Outdated
|
|
||
| RUN <<EOF | ||
| if [[ "$PULP_UI_URL" ]]; then | ||
| mkdir -p /usr/share/nginx/static/pulp_ui |
There was a problem hiding this comment.
Is this the new /var/www ?
It's OK...
There was a problem hiding this comment.
Where should these files live? I was thinking I could put them in the pulp static directory (default: /var/lib/operator/static/), but I was worried if the user ran collectstatic with --clean then they would lose their UI as well.
images/pulp/stable/Containerfile
Outdated
|
|
||
| ENV PULP_UI=true |
There was a problem hiding this comment.
This should probably depend on PULP_UI_URL... Or let's just make PULP_UI_URL the env var?
| @@ -105,6 +105,17 @@ http { | |||
|
|
|||
| include pulp/*.conf; | |||
|
|
|||
| {% if ui | default(false) -%} | |||
There was a problem hiding this comment.
This could be if ui_url != ""?
images/pulp/stable/Containerfile
Outdated
| RUN <<EOF | ||
| if [[ "$PULP_UI_URL" ]]; then | ||
| mkdir -p "${PULP_STATIC_ROOT}pulp_ui" | ||
| curl -Ls $PULP_UI_URL | tar -xzv -C "${PULP_STATIC_ROOT}pulp_ui" | ||
| fi | ||
| EOF |
There was a problem hiding this comment.
I haven't seen this "here document" thing in a container file before.
Can you try with \ on each lines end instead?
There was a problem hiding this comment.
I couldn't get it to work with \.
There was a problem hiding this comment.
Ok I got a version with \ to work, had to switch to using single [ for the if check.
gerrod3
force-pushed
the
pulp-ui
branch
11 times, most recently
from
4bfb1f9
to
bc878aa
Compare
There's many different ways to serve these files, here's one way I chose. Would like some feedback on this approach.
TODO: