Updating communities based on feedback (#1973)

fixes #1970

app/models/group.rb

@@ -159,9 +159,10 @@ def communities
     if code == "PPPL"
       ["Princeton Plasma Physics Laboratory"]
     else
-      ["Princeton Neuroscience Institute", "Department of Geosciences", "Mechanical and Aerospace Engineering",
+      ["Princeton Neuroscience Institute", "Geosciences", "Mechanical and Aerospace Engineering",
        "Astrophysical Sciences", "Civil and Environmental Engineering", "Chemical and Biological Engineering",
-       "Digital Humanities", "Music and Arts", "Princeton School of Public and International Affairs"].sort
+       "Digital Humanities", "Music and Arts", "Princeton School of Public and International Affairs",
+       "Chemistry", "Lewis Seigler Genomics", "Architecture", "Ecology and Evolutionary Biology", "Economics"].sort
     end
   end
 

db/migrate/20241021194327_deparment_community.rb

@@ -0,0 +1,9 @@
+class DeparmentCommunity < ActiveRecord::Migration[7.2]
+  def change
+    Work.where("metadata @> ?", JSON.dump(communities: ["Department of Geosciences"])).each do |work|
+      communities = work.resource.communities
+      work.resource.communities = communities.map {|community| community == "Department of Geosciences" ? "Geosciences" : community }
+      work.save
+    end
+  end
+end

spec/models/group_spec.rb

@@ -30,7 +30,7 @@
   it "sorts alphabetically communities and subcommunities" do
     described_class.create_defaults
     group_rd = described_class.where(code: "RD").first
-    expect(group_rd.communities.first).to eq "Astrophysical Sciences"
+    expect(group_rd.communities.first).to eq "Architecture"
     expect(group_rd.communities.last).to eq "Princeton School of Public and International Affairs"
 
     group_pppl = described_class.where(code: "PPPL").first

spec/system/work_edit_spec.rb

@@ -205,10 +205,10 @@
       sign_in user
       visit edit_work_path(work)
       click_on "Additional Metadata"
-      select "Department of Geosciences", from: "communities"
+      select "Geosciences", from: "communities"
       expect(page).to_not have_content("Subcommunities")
       click_on "Save Work"
-      expect(page).to have_content("Department of Geosciences")
+      expect(page).to have_content("Geosciences")
     end
   end