Wording Updates (#4691)

* Update per issue #4688. * Updates collection descriptions statement per #4687. * Update wording on suggest a correction. Per #4690 * Remove report harmful language feature, asssociated wording, and specs. For #4689.
pulibrary · Jan 10, 2025 · 7497a7d · 7497a7d
1 parent 53c1717
commit 7497a7d
Show file tree

Hide file tree

Showing 24 changed files with 19 additions and 403 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -98,7 +98,6 @@ Layout/LineContinuationSpacing:
     - 'app/helpers/blacklight_helper.rb'
     - 'spec/forms/ask_a_question_form_spec.rb'
     - 'spec/forms/feedback_form_spec.rb'
-    - 'spec/forms/report_harmful_language_form_spec.rb'
     - 'spec/forms/suggest_correction_form_spec.rb'
     - 'spec/models/email_spec.rb'
     - 'spec/models/feedback_form_submission_spec.rb'
@@ -119,7 +118,6 @@ Layout/LineEndStringConcatenationIndentation:
     - 'spec/features/requests/form_spec.rb'
     - 'spec/forms/ask_a_question_form_spec.rb'
     - 'spec/forms/feedback_form_spec.rb'
-    - 'spec/forms/report_harmful_language_form_spec.rb'
     - 'spec/forms/suggest_correction_form_spec.rb'
     - 'spec/models/feedback_form_submission_spec.rb'
     - 'spec/models/illiad_patron_client_spec.rb'

diff --git a/app/controllers/contact_controller.rb b/app/controllers/contact_controller.rb
@@ -22,17 +22,6 @@ def suggestion
     end
   end
 
-  def report_harmful_language
-    @form = ReportHarmfulLanguageForm.new(report_harmful_language_params)
-    if @form.valid? && @form.submit
-      flash[:success] = 'Your report has been submitted'
-
-      render "report_harmful_language_success"
-    else
-      render partial: "catalog/report_harmful_language_form", locals: { form: @form }
-    end
-  end
-
   def report_biased_results
     @form = ReportBiasedResultsForm.new(report_biased_results_params)
     if @form.valid? && @form.submit
@@ -54,10 +43,6 @@ def suggestion_params
       params[:suggest_correction_form].permit!
     end
 
-    def report_harmful_language_params
-      params[:report_harmful_language_form].permit!
-    end
-
     def report_biased_results_params
       params[:report_biased_results_form].permit!
     end

diff --git a/app/controllers/feedback_controller.rb b/app/controllers/feedback_controller.rb
@@ -7,7 +7,6 @@ class FeedbackController < ApplicationController
   before_action :build_feedback_form, only: [:create]
   before_action :build_ask_a_question_form, only: [:ask_a_question]
   before_action :build_suggest_correction_form, only: [:suggest_correction]
-  before_action :build_report_harmful_language_form, only: [:report_harmful_language]
   before_action :build_report_biased_results_form, only: [:report_biased_results]
 
   def new
@@ -30,8 +29,6 @@ def ask_a_question; end
 
   def suggest_correction; end
 
-  def report_harmful_language; end
-
   def report_biased_results; end
 
   protected
@@ -68,17 +65,6 @@ def suggest_correction_form_params
       params.require(:suggest_correction_form).permit(:id, :title)
     end
 
-    def build_report_harmful_language_form
-      @harmful_language_form = ReportHarmfulLanguageForm.new(
-        context: page_url(harmful_language_params),
-        title: harmful_language_params['title']
-      )
-    end
-
-    def harmful_language_params
-      params.require(:report_harmful_language_form).permit(:id, :title)
-    end
-
     def build_report_biased_results_form
       @biased_results_form = ReportBiasedResultsForm.new(
         biased_results_params

diff --git a/app/forms/report_harmful_language_form.rb b/app/forms/report_harmful_language_form.rb
diff --git a/app/views/catalog/_home_text.html.erb b/app/views/catalog/_home_text.html.erb
@@ -30,10 +30,10 @@
     <span class="icon-language-statement" aria-hidden="true"></span>
   </div>
   <div class="language-statement-text">
-    <%= link_to "https://library.princeton.edu/about/languagestatement", 'aria-label': "Read more about Statement on language in description" do %>
-      <h3>Statement on language in description</h3>
+    <%= link_to "https://library.princeton.edu/about/responsible-collection-description", 'aria-label': "Read more about the statement on responsible collection description" do %>
+      <h3>Statement on Responsible Collection Description</h3>
     <% end %>
-    <p>Princeton University Library aims to describe library materials in a manner that is respectful to the individuals and communities who create, use, and are represented in the collections we manage. <a href="https://library.princeton.edu/about/languagestatement" aria-label="Read more about Statement on language in description" class='underlined-link'>Read more...</a></p>
+    <p>Princeton University Library (PUL) stewards diverse historical and contemporary collections that document a wide range of human experiences. As an academic and cultural heritage institution, we preserve materials in their original form to maintain historical accuracy and support scholarly research. This includes retaining content that may reflect perspectives which some users may find oﬀensive or otherwise problematic. <a href="https://library.princeton.edu/about/responsible-collection-description" aria-label="Read more about the statement on responsible collection description" class='underlined-link'>Read more...</a></p>
   </div>
 </div>
 

diff --git a/app/views/catalog/_report_harmful_language_form.html.erb b/app/views/catalog/_report_harmful_language_form.html.erb
diff --git a/app/views/catalog/_show_harmful_content_feedback.html.erb b/app/views/catalog/_show_harmful_content_feedback.html.erb
@@ -27,18 +27,4 @@
     class: "suggest-correction",
     data: { blacklight_modal: 'trigger' }
     ) %>
-  <%= link_to(
-    'Report Harmful Language',
-    {
-      controller: "feedback",
-      action: "report_harmful_language",
-      report_harmful_language_form: { 
-        id: @document,
-        title: @document['title_display']
-      }
-    },
-    title: "Report Harmful Language",
-    class: "report-harmful-language",
-    data: { blacklight_modal: 'trigger' }
-  ) %>
 </nav>
diff --git a/app/views/catalog/_statement_on_language_in_description.html.erb b/app/views/catalog/_statement_on_language_in_description.html.erb
@@ -1,4 +1,3 @@
-<dt>Statement on language in description</dt>
-<dd>Princeton University Library aims to describe library materials in a manner that is respectful to the individuals and communities who create, use, and are represented in the collections we manage.
-<a href="https://library.princeton.edu/about/languagestatement" target="_blank"
-   aria-label="Read more about Statement on language in description (opens in new tab)">Read more...</a></dd>
+<dt>Statement on responsible collection description</dt>
+<dd>Princeton University Library aims to describe library materials in a manner that is respectful to the individuals and communities who create, use, and are represented in the collections we manage. <a href="https://library.princeton.edu/about/responsible-collection-description" target="_blank"
+   aria-label="Read more about Statement responsible collection description (opens in new tab)">Read more...</a></dd>
diff --git a/app/views/catalog/_suggest_correction_form.html.erb b/app/views/catalog/_suggest_correction_form.html.erb
@@ -9,7 +9,7 @@
   ) do |f|
 %>
   <div class="modal-body">
-    <p>Please use this area to report errors or omissions that appear in the description of this record.</p>
+    <p>Please use this form to report errors, omissions, or problematic language that appear in the description of this record.</p>
     <%= f.label :name %><br>
     <%= f.input_field :name %><br>
     <%= f.label :email %><br>

diff --git a/app/views/contact/report_biased_results_success.erb b/app/views/contact/report_biased_results_success.erb
@@ -1,5 +1,5 @@
 <%= render Blacklight::System::ModalComponent.new do |component| %>
-  <% component.with_title { t('blacklight.report_harmful_language.form.title') } %>
+  <% component.with_title { t('blacklight.report_biased_results.form.title') } %>
 
   <%= render partial: '/shared/flash_msg' %>
   <p>Thank you for helping us identify an instance of bias in our Catalog Search Results.

diff --git a/app/views/contact/report_harmful_language_success.html.erb b/app/views/contact/report_harmful_language_success.html.erb
diff --git a/app/views/feedback/report_harmful_language.html.erb b/app/views/feedback/report_harmful_language.html.erb
diff --git a/config/locales/blacklight.en.yml b/config/locales/blacklight.en.yml
@@ -93,9 +93,6 @@ en:
     suggest_correction:
       form:
         title: 'Suggest a Correction'
-    report_harmful_language:
-      form:
-        title: 'Report Harmful Language'
     report_biased_results:
       form:
         title: 'Report Biased Results'    

diff --git a/config/orangelight.yml b/config/orangelight.yml
@@ -8,8 +8,6 @@ defaults: &defaults
     queue_id: <%= ENV['ASK_A_QUESTION_QUEUE_ID'] %>
   suggest_correction_form:
     queue_id: <%= ENV['SUGGEST_CORRECTION_QUEUE_ID'] %>
-  report_harmful_language_form:
-    queue_id: <%= ENV['REPORT_HARMFUL_LANGUAGE_QUEUE_ID'] %>
   report_biased_results_form:
     to: <%= ENV['OL_BIASED_RESULTS_TO'] %>
   redis:
@@ -35,8 +33,6 @@ development:
     db: 'orangelight_dev'
   suggest_correction_form:
     queue_id: <%= ENV['SUGGEST_CORRECTION_QUEUE_ID'] %>
-  report_harmful_language_form:
-    queue_id: <%= ENV['REPORT_HARMFUL_LANGUAGE_QUEUE_ID'] %>
   report_biased_results_form:
     to: '[email protected]'
 test:
@@ -51,8 +47,6 @@ test:
     db: 'orangelight_test'
   suggest_correction_form:
     queue_id: 3456
-  report_harmful_language_form:
-    queue_id: 9012
   report_biased_results_form:
     to: '[email protected]'
   libanswers:

diff --git a/docs/viewer_warning.md b/docs/viewer_warning.md
@@ -9,7 +9,7 @@ In order to view the content a user would have to press the button 'View Content
   * Notice type: Harmful Content,  
     Displayed message:  
     * Content Warning,  
-         This collection includes materials and images that are harmful (in that they are racist, transphobic, or otherwise demeaning). For more information on harmful content please see the [PUL statement on Harmful Content](https://library.princeton.edu/statement-harmful-content)  
+           This collection includes materials and images that may reflect perspectives which some users could find oﬀensive or otherwise problematic. For more information, please see the [PUL statement on Responsible Collection Description](https://library.princeton.edu/about/responsible-collection-description).
 
         View Content
 

diff --git a/spec/controllers/feedback_controller_spec.rb b/spec/controllers/feedback_controller_spec.rb
@@ -10,14 +10,6 @@
     end
   end
 
-  describe "#report_harmful_language" do
-    it "routes to the Report Harmful Language form" do
-      get :report_harmful_language, params: { report_harmful_language_form: { id: '123', title: 'My cool title' } }
-
-      expect(response).to be_successful
-    end
-  end
-
   describe "#report_biased_results" do
     it "routes to the Report Biased Results form" do
       get :report_biased_results, params: {

diff --git a/spec/features/report_harmful_language_spec.rb b/spec/features/report_harmful_language_spec.rb