Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Fix getMemberships ignoring uuid parameter #306

Merged
merged 2 commits into from
Nov 6, 2024
Merged

[JS] Fix getMemberships ignoring uuid parameter #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69e3168
[JS] Fix getMemberships ignoring `uuid` parameter
wkal-pubnub Nov 5, 2024
ac7314e
Merge branch 'master' into wkal/chat_js_wrapper2
wkal-pubnub Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...in/pubnub-kotlin-api/src/commonTest/kotlin/com/pubnub/test/integration/MembershipsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,25 @@ class MembershipsTest : BaseIntegrationTest() {
assertEquals(customData, pnChannelDetails.custom?.value)
}

@Test
fun can_set_and_get_memberships_for_other_uuid() = runTest {
// when
val userId = "some-user-" + randomString()
pubnub.setMemberships(
channels = listOf(PNChannelMembership.Partial(channel, custom, status)),
uuid = userId,
includeCustom = includeCustom,
includeChannelDetails = PNChannelDetailsLevel.CHANNEL_WITH_CUSTOM,
).await()

val result = pubnub.getMemberships(uuid = userId, filter = "channel.id == '$channel'", includeCustom = true).await()

// then
val pnChannelDetails = result.data.single { it.channel.id == channel }
assertEquals(channel, pnChannelDetails.channel.id)
assertEquals(customData, pnChannelDetails.custom?.value)
}

@Test
fun can_receive_set_membership_event() = runTest {
pubnub.test(backgroundScope) {
Expand Down
3 changes: 2 additions & 1 deletion ...kotlin/pubnub-kotlin-api/src/commonTest/kotlin/com/pubnub/test/integration/PublishTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import com.pubnub.api.models.consumer.pubsub.PNSignalResult
import com.pubnub.kmp.PLATFORM
import com.pubnub.test.BaseIntegrationTest
import com.pubnub.test.await
import com.pubnub.test.randomString
import com.pubnub.test.test
import kotlinx.coroutines.test.runTest
import kotlin.js.JsExport
Expand All @@ -27,7 +28,7 @@ data class ABC(
)

class PublishTest : BaseIntegrationTest() {
private val channel = "myChannel"
private val channel = "myChannel" + randomString()

@Test
fun can_publish_message_string() =
Expand Down
1 change: 1 addition & 0 deletions pubnub-kotlin/pubnub-kotlin-api/src/jsMain/kotlin/com/pubnub/api/PubNubImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,7 @@ class PubNubImpl(val jsPubNub: PubNubJs) : PubNub {
return GetMembershipsImpl(
jsPubNub,
createJsObject {
uuid?.let { this.uuid = it }
this.sort = sort.toJsMap()
this.filter = filter
this.page = page.toMetadataPage()
Expand Down
Loading