Added customMessageType to Publish, Signal, Subscribe, History, File. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
requested review from
kleewho,
wkal-pubnub and
jguz-pubnub
as code owners
wkal-pubnub
requested changes
Oct 28, 2024
pubnub-gson/pubnub-gson-impl/src/main/java/com/pubnub/internal/java/PubNubForJavaImpl.kt
Show resolved
Hide resolved
| channel.publish( | ||
| message = generatePayload(), | ||
| customMessageType = expectedCustomMessageType | ||
| ).await { resutl: Result<PNPublishResult> -> |
There was a problem hiding this comment.
this await could just be .sync() I think?
There was a problem hiding this comment.
ok, I will change it.
| @@ -93,6 +98,8 @@ class PublishEndpoint internal constructor( | |||
| queryParams["norep"] = true.valueString | |||
| } | |||
|
|
|||
| customMessageType?.run { queryParams[CUSTOM_MESSAGE_TYPE_QUERY_PARAM] = this } | |||
There was a problem hiding this comment.
nit: I prefer to use .let { it -> } in situations when changing the receiver (this) is not required or beneficial.
For example this could easily be ?.let { queryParams[CUSTOM_MESSAGE_TYPE_QUERY_PARAM] = it } and then we don't have the this change
There was a problem hiding this comment.
I would also use .let but I wanted to be in line with approach used in this method where there are:
meta?.run { queryParams["meta"] = pubnub.mapper.toJson(this) }
shouldStore?.run { queryParams["store"] = this.numericString }
ttl?.run { queryParams["ttl"] = this.toString() }
I will refactor this method to use:
.?.let {}
marcin-cebo
force-pushed
the
mc/customMessageType
branch
from
9488fa7
to
cb101dd
Compare
wkal-pubnub
reviewed
Oct 29, 2024
...e-api/src/commonMain/kotlin/com/pubnub/api/models/consumer/pubsub/files/PNFileEventResult.kt
Show resolved
Hide resolved
wkal-pubnub
approved these changes
Nov 4, 2024
only fetchMessages
marcin-cebo
force-pushed
the
mc/customMessageType
branch
from
b1495df
to
2df2968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.