Fix and enable JS build #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkal-pubnub
requested review from
kleewho,
marcin-cebo and
jguz-pubnub
as code owners
wkal-pubnub
force-pushed
the
wkal/js_build
branch
from
88d8614
to
2416151
Compare
marcin-cebo
approved these changes
Oct 3, 2024
| uuid.eTag, | ||
| uuid.type, | ||
| uuid.status | ||
| PatchValue.of(uuid.name), // TODO support optionals |
There was a problem hiding this comment.
What does it mean "support optionals" here?
There was a problem hiding this comment.
right now it just takes nulls and puts them in PatchValue so it's not really optional, it's just always a value (which can be null)
I have to see if there's a way to get the information from JS SDK about the presence (or absence) of value
pubnub-kotlin/pubnub-kotlin-api/src/jsMain/kotlin/com/pubnub/kmp/factories.js.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.