Fix crash on Android in retry logic after destroy called #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkal-pubnub
requested review from
kleewho,
marcin-cebo and
jguz-pubnub
as code owners
marcin-cebo
approved these changes
Aug 16, 2024
|
@pubnub-release-bot release kotlin as v9.2.4 |
|
🚀 Release successfully completed 🚀 |
wkal-pubnub
added a commit
that referenced
this pull request
Sep 16, 2024
* Use large GitHub runner (#219) build(runner): change runner groups * Disallow DTDs in XML parser (#222) * Disallow DTDs in XML parser * GCM to FCM migration in PushPayloadHelper (#227) * GCM to FCM migration in PushPayloadHelper * Mc/add integ test (#226) * v.9.2.0 release with FCMPayloadV2 * Enforce string-only values in data * Fix enum values and use deprecation instead of breaking change * PubNub SDK v9.2.0 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Added sorting to integ test. (#233) * Add missing auth_method to APNS2 configuration (#249) * Add missing auth_method to APNS2 configuration * PubNub SDK v9.2.1 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * SetState via Heartbeat fix. (#251) * PubNub SDK v9.2.2 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Fix RetryRemoteAction double callback (#262) * Fix RetryRemoteAction double callback * PubNub SDK v9.2.3 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Java SDK now depends on Kotlin SDK * java.Subscription should not inherint kotlin.Subscription * Some more minor changes, migration generator * Rename PubNubForJava to PubNub * Fix crash on Android in retry logic after destroy called (#270) * Fix crash on Android in retry logic after destroy called * PubNub SDK v9.2.4 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Fix iOS build * Move checkstyle settings to plugin --------- Co-authored-by: Serhii Mamontov <[email protected]> Co-authored-by: marcin-cebo <[email protected]> Co-authored-by: PubNub Release Bot <[email protected]> Co-authored-by: marcin.cebo <[email protected]>
wkal-pubnub
added a commit
that referenced
this pull request
Sep 20, 2024
* Base KMP structure with no JS or iOS implementations. * Change Any to Map for custom in PNChannelMetadata * Add JS wrappers for some endpoints (#212) * Add JS wrappers for some endpoints * Fix exception due to non working expect/actual annotation * First tests for common code * Add Swift wrappers for some endpoints * Add unsubscribeAll * Allow running tests on iOS * Add back imports --------- Co-authored-by: jguz-pubnub <[email protected]> * Continue adding JS implementations for KMP (#215) * Add JS wrappers for some endpoints * First tests for common code * Add integrationTest gradle task * [JS] Fix JsonElement casts * We can run iOS tests now. * Configurable iOS simulator through gradle.properties * Make listeners work in JS and update PublishTest * Only run simulator tasks on macOs hosts * Add getState, deleteChannelGroup and grantToken for JS KMP * Add mapCatching to Result * Kotlin 2.0, keys in tests, more JS endpoints (#217) * [JS] Time and UUIDMetadata endpoints * Bump Kotlin version to 2.0.0 stable * Add buildKonfig for loading API keys in tests * Don't fail on missing test.properties * Added Swift wrappers for push notification methods (#216) * UUID & channel metadata (#218) * Tests for UUID metadata + setChannelMetadata test and impl * Channel metadata get & remove, tests & impl * Fix sort parameter * Added Swift wrappers for next endpoints (#221) * JS cleanups and membership related endpoints (#220) * [JS] membership related methods * [JS] Cleanup PN JS bindings file * [JS] Deduplicate data converters * [JS] Fixing memberships events and adding tests (WIP) * Tests continued * [IOS] catch exception in mapper + formatting * Wrapping next Swift endpoints (#224) * Message payloads, metadata & status code in exceptions (#223) * Use large GitHub runner (#219) build(runner): change runner groups * Get message payload and metadata working in iOS and tests * Disallow DTDs in XML parser (#222) * Disallow DTDs in XML parser * [Common] Add status code to PubNubException * delete unneeded codable * Fix build --------- Co-authored-by: Serhii Mamontov <[email protected]> * Add wrapException to Result * Wrapping status listener and some AppContext methods (#225) * Add creation of JsonElement to common code (#228) * Allow creation of JsonElement for tests * Merge changes from master * Add Swift git submodule (#230) * Added constructor for testing purpose. (#231) * Merge master changes to kmp branch (#234) * Use large GitHub runner (#219) build(runner): change runner groups * Disallow DTDs in XML parser (#222) * Disallow DTDs in XML parser * GCM to FCM migration in PushPayloadHelper (#227) * GCM to FCM migration in PushPayloadHelper * Mc/add integ test (#226) * v.9.2.0 release with FCMPayloadV2 * Enforce string-only values in data * Fix enum values and use deprecation instead of breaking change * PubNub SDK v9.2.0 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> --------- Co-authored-by: Serhii Mamontov <[email protected]> Co-authored-by: marcin-cebo <[email protected]> Co-authored-by: PubNub Release Bot <[email protected]> * Wrapping next AppContext methods (#229) * [KMP] Move tests and make more tests work on iOS (#235) * [JS] Add files related methods (#236) * [JS] Add all file methods * PNFuture chaining methods * More PNFuture composing functions * PNFuture.awaitAll types fix * Merge fixes * Fix futures package * Wrapping remaining AppContext methods + Files API (#237) * Finish rest of required JS wrapper methods (basic entity/subscription support) (#238) * Commonize entities and subscriptions * Remove expect/actual PubNub interfaces * [JS] Basic channel entity and subscription * [JS] Add missing methods * Alias c.p.kmp.PubNub and import c.p.api.PubNub * File download + File upload (#239) * Wrapping entities and Subscription/SubscriptionSet (#241) * Add IncludeType, fix futures.awaitAll and listener classcastexception on JS (#240) * Changes for integration tests, add includeType * Add includeType and fix PNFuture * Listener fixes * Minor improvements for iosMain (#242) * Getting rid of warnings related to Maps * Ensuring that JsonImpl is used as expected * Added some missing implementations in PubNubImpl.kt * Updated submodule * Added secret key to configuration (#243) * Added secret key for tests (#244) * PNFuture variance fix (#245) * SubscriptionSetImpl in JS and PNFuture.remember() (#246) * Tests, fixes (#247) * Various JS test fixes * More JS tests * More tests * More KMP tests (#248) * More tests and fixing equality checks in JSONElement * Change GSON number strategy to lazily parsed (#250) All custom objects will contain Number in place of integers or doubles that need to be changed to desired concrete types with toLong etc. This is a breaking change. * Fixes for custom fields (AppContext) and push methods (#252) * Fixes for custom fields (AppContext) and push methods * Fix for SetChannelMembersImpl * Added missing changes from swift repository * Fix for factories.ios.kt * Some test fixes --------- Co-authored-by: Wojciech Kaliciński <[email protected]> * Change actionTimetoken to Long, ktlint, tests (#253) * More tests * Change timetokens to long * Re-add ktLint * parseToken and test fixture changes (#254) * Refactoring around PNConfiguration (#255) * Fixing integration tests for iOS (#256) * iOS test changes (#257) * Add JsonElement test * Changes for Chat project * Get rid of com.pubnub.kmp.PubNub (#261) * Using InputStream instead of URL in StreamUploadContent (#259) * Merge changes from master to kmp-dev (#263) * Use large GitHub runner (#219) build(runner): change runner groups * Disallow DTDs in XML parser (#222) * Disallow DTDs in XML parser * GCM to FCM migration in PushPayloadHelper (#227) * GCM to FCM migration in PushPayloadHelper * Mc/add integ test (#226) * v.9.2.0 release with FCMPayloadV2 * Enforce string-only values in data * Fix enum values and use deprecation instead of breaking change * PubNub SDK v9.2.0 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Added sorting to integ test. (#233) * Add missing auth_method to APNS2 configuration (#249) * Add missing auth_method to APNS2 configuration * PubNub SDK v9.2.1 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * SetState via Heartbeat fix. (#251) * PubNub SDK v9.2.2 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Fix RetryRemoteAction double callback (#262) * Fix RetryRemoteAction double callback * PubNub SDK v9.2.3 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * lint --------- Co-authored-by: Serhii Mamontov <[email protected]> Co-authored-by: marcin-cebo <[email protected]> Co-authored-by: PubNub Release Bot <[email protected]> * Fix obvious typo in JS wrapper * Handling missing includeType parameter (AppContext) (#264) * Build scripts with non-JVM targets disabled (#265) * Selectively enable targets * Add test logging * Move integration tests * Revert configuration caching * Test utils for kmp-chat * [Kotlin] Change PNChannelMetadata and PNUUIDMetadata to contain partial update information (#266) * Add partial updates when querying channel metadata * Add partial updates when querying user metadata * Deprecate TTL parameter in PubNub.fire() * Partial updates for membership information (#267) * Added missing implementations for iOS target (#268) * Version bumps, test fixture fix (#273) * Handling missing ReceivePresenceEvents options (#274) * Updating Channel/UUID metadata with PatchValue (#271) * Fixes according to swift module changes (#276) * Fixed import statements in iosMain due to names refactor (adding the KMP prefix) in the swift submodule * Made changes in the swift submodule, replacing the product name with PubNubSDK * Changed module name in PubNubKotlinMultiplatformPlugin.kt due to the point mentioned above * Change dependencies so that Java SDK depends on Kotlin SDK (#269) * Use large GitHub runner (#219) build(runner): change runner groups * Disallow DTDs in XML parser (#222) * Disallow DTDs in XML parser * GCM to FCM migration in PushPayloadHelper (#227) * GCM to FCM migration in PushPayloadHelper * Mc/add integ test (#226) * v.9.2.0 release with FCMPayloadV2 * Enforce string-only values in data * Fix enum values and use deprecation instead of breaking change * PubNub SDK v9.2.0 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Added sorting to integ test. (#233) * Add missing auth_method to APNS2 configuration (#249) * Add missing auth_method to APNS2 configuration * PubNub SDK v9.2.1 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * SetState via Heartbeat fix. (#251) * PubNub SDK v9.2.2 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Fix RetryRemoteAction double callback (#262) * Fix RetryRemoteAction double callback * PubNub SDK v9.2.3 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Java SDK now depends on Kotlin SDK * java.Subscription should not inherint kotlin.Subscription * Some more minor changes, migration generator * Rename PubNubForJava to PubNub * Fix crash on Android in retry logic after destroy called (#270) * Fix crash on Android in retry logic after destroy called * PubNub SDK v9.2.4 release. --------- Co-authored-by: PubNub Release Bot <[email protected]> * Fix iOS build * Move checkstyle settings to plugin --------- Co-authored-by: Serhii Mamontov <[email protected]> Co-authored-by: marcin-cebo <[email protected]> Co-authored-by: PubNub Release Bot <[email protected]> Co-authored-by: marcin.cebo <[email protected]> * Small fixes after merge * Updating swift submodule (#278) * Uploading swift submodule with recent changes from master * Setting uuid field in KMPPresenceChange.swift * Added @ObjCName annotation and helper constructor (iOS) (#280) * Add PatchValue to Java API (#281) * Add PatchValue to Java API * Change custom Object to Map in Java * Formatting --------- Co-authored-by: jguz-pubnub <[email protected]> Co-authored-by: jguz-pubnub <[email protected]> Co-authored-by: Serhii Mamontov <[email protected]> Co-authored-by: marcin-cebo <[email protected]> Co-authored-by: PubNub Release Bot <[email protected]> Co-authored-by: marcin.cebo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fixes a crash on Android after
PubNub.destroyis called and there are requests running